[FFmpeg-devel] [PATCH 2/2] Revert "Disable warnings for casting pointers to integers, there is nothing wrong with that."

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Fri Nov 26 08:41:37 EET 2021


Andreas Rheinhardt:
> This reverts commit 5258f64a14713499cf84840b3ab3a1ee7cdcaeb8.
> The premise of said commit (that conversions from pointer to int
> are ok) is wrong: C99/C11 6.3.2.3 5: "Any pointer type may be converted
> to an integer type. [...] If the result cannot be represented in the
> integer type, the behavior is undefined." (C90 6.3.4 contains a similar
> restriction.) So don't disable -Wpointer-to-int-cast.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> ---
>  configure | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/configure b/configure
> index d068b11073..82e60b5da3 100755
> --- a/configure
> +++ b/configure
> @@ -6903,7 +6903,6 @@ check_cflags -Wwrite-strings
>  check_cflags -Wtype-limits
>  check_cflags -Wundef
>  check_cflags -Wmissing-prototypes
> -check_cflags -Wno-pointer-to-int-cast
>  check_cflags -Wstrict-prototypes
>  check_cflags -Wempty-body
>  
> 

Will apply tonight unless there are objections.

- Andreas


More information about the ffmpeg-devel mailing list