[FFmpeg-devel] [PATCH 3/4] avutil/hwcontext_vulkan: check if created before destroying the instance

[Wu Jianhua]

Dennis Mungai<mailto:dmngaie at gmail.com>:
> Sent: 2021年11月23日 22:58
> To: FFmpeg development discussions and patches<mailto:ffmpeg-devel at ffmpeg.org>
> Cc: Wu Jianhua<mailto:jianhua.wu at intel.com>
> Subject: Re: [FFmpeg-devel] [PATCH 3/4] avutil/hwcontext_vulkan: check if created before destroying the instance
>
> On Tue, 23 Nov 2021, 12:06 Wu Jianhua, <jianhua.wu at intel.com> wrote:
>
>> Signed-off-by: Wu Jianhua <jianhua.wu at intel.com>
>> ---
>>  libavutil/hwcontext_vulkan.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c
>> index 4ac1058181..644ed947f8 100644
>> --- a/libavutil/hwcontext_vulkan.c
>> +++ b/libavutil/hwcontext_vulkan.c
>> @@ -1157,7 +1157,8 @@ static void vulkan_device_free(AVHWDeviceContext
>> *ctx)
>>          vk->DestroyDebugUtilsMessengerEXT(hwctx->inst, p->debug_ctx,
>>                                            hwctx->alloc);
>>
>> -    vk->DestroyInstance(hwctx->inst, hwctx->alloc);
>> +    if (hwctx->inst)
>> +        vk->DestroyInstance(hwctx->inst, hwctx->alloc);
>>
>>      if (p->libvulkan)
>>          dlclose(p->libvulkan);
>> --
>> 2.25.1
>>
>
> Ping.
>
> This fixes a (somewhat obscure) bug where a "generic library error" is
> reported when running multiple concurrent ffmpeg commands with one or more
> Vulkan filter chains.
>

Hi Dennis:

Glad that this patch is helpful, but I’m unable to do more. Lynne may help apply
this patch when she sees your ping.

Thanks,
Jianhua