[FFmpeg-devel] [PATCH v3 3/4] avformat/imf: Demuxer implementation

[Pierre-Anthony Lemieux]

On Mon, Nov 22, 2021 at 12:37 PM Paul B Mahol <onemda at gmail.com> wrote:
>
>
>
> On Mon, Nov 22, 2021 at 5:35 PM Pierre-Anthony Lemieux <pal at sandflow.com> wrote:
>>
>> Hi Paul,
>>
>> Thanks for the review.
>>
>> Are you saying that, in the event that any memory allocation fails
>> within the demuxer, the demuxer is responsible for cleaning-up already
>> previously allocated memory so that other parts of the pipeline can
>> continue operating? In other words, ffmpeg is not expected to
>> immediately die if memory allocation fails in one
>> demuxer/decoder/muxer?
>
>
>
> I'm saying it leaks memory because it overwrites old pointer with NULL.
>

Got it. Will fix now.

>>
>>
>> I just want to make sure I understand the feedback.
>>
>> Best,
>>
>> -- Pierre
>>
>> On Mon, Nov 22, 2021 at 3:19 AM Paul B Mahol <onemda at gmail.com> wrote:
>> >
>> >
>> > The realloc calls still leaks on error.