[FFmpeg-devel] [PATCH v1] avfilter: add overlay vaapi filter

[Soft Works]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Wang, Fei W
> Sent: Friday, November 19, 2021 2:15 AM
> To: ffmpeg-devel at ffmpeg.org
> Cc: Sun, Xinpeng <xinpeng.sun at intel.com>; Zhou, Zachary
> <zachary.zhou at intel.com>
> Subject: Re: [FFmpeg-devel] [PATCH v1] avfilter: add overlay vaapi
> filter
> 
> On Thu, 2021-11-18 at 21:55 +0000, Soft Works wrote:
> > > -----Original Message-----
> > > From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> > > Fei
> > > Wang
> > > Sent: Tuesday, June 30, 2020 5:58 AM
> > > To: ffmpeg-devel at ffmpeg.org
> > > Cc: Xinpeng Sun <xinpeng.sun at intel.com>; Zachary Zhou
> > > <zachary.zhou at intel.com>; Fei Wang <fei.w.wang at intel.com>
> > > Subject: [FFmpeg-devel] [PATCH v1] avfilter: add overlay vaapi
> > > filter
> > >
> > > From: Xinpeng Sun <xinpeng.sun at intel.com>
> > >
> > > Overlay one video on the top of another.
> > >
> > > It takes two inputs and has one output. The first input is the
> > > "main"
> > > video on
> > > which the second input is overlaid. This filter requires same
> > > memory
> > > layout for
> > > all the inputs.
> > >
> > > An example command to use this filter to overlay an image LOGO at
> > > the
> > > top-left
> > > corner of the INPUT video and both inputs are h264 file:
> > >
> > > ffmpeg -hwaccel vaapi -vaapi_device /dev/dri/renderD128 \
> > > -hwaccel_output_format vaapi -i INPUT.h264 -hwaccel vaapi \
> > > -vaapi_device /dev/dri/renderD128 -hwaccel_output_format vaapi -i
> \
> > > LOGO.h264 -filter_complex
> > > "[0:v][1:v]overlay_vaapi=w=50:h=50:alpha=0.5" \
> > > -c:v h264_vaapi -y OUTPUT.h264
> > >
> > > Signed-off-by: Xinpeng Sun <xinpeng.sun at intel.com>
> > > Signed-off-by: Zachary Zhou <zachary.zhou at intel.com>
> > > Signed-off-by: Fei Wang <fei.w.wang at intel.com>
> > > ---
> >
> > Does anybody know why this filter hasn't been merged?
> > I always thought it would have been included for quite a while.
> >
> > Is there any problem with it?
> 
> Because nobody helped to review/apply it. It works base on our local
> test. If anybody can help to apply it, I will submit a new version to
> port it to latest mater.

I can't merge but I'm ready to review it. The patch from cartwheel
doesn't apply either, so when you could supply an updated patch, that
would be great.

Thanks,
softworkz