[FFmpeg-devel] [PATCH] avfilter: add colorvd video filter

[James Almer]

On 11/19/2021 11:38 AM, Paul B Mahol wrote:
> On Fri, Nov 19, 2021 at 3:29 PM James Almer <jamrial at gmail.com> wrote:
> 
>> On 11/19/2021 11:07 AM, Paul B Mahol wrote:
>>> On Fri, Nov 19, 2021 at 3:04 PM Anton Khirnov <anton at khirnov.net> wrote:
>>>
>>>> Quoting Paul B Mahol (2021-11-19 14:55:42)
>>>>> On Fri, Nov 19, 2021 at 2:27 PM Michael Niedermayer <
>>>> michael at niedermayer.cc>
>>>>> wrote:
>>>>>
>>>>>> On Fri, Nov 19, 2021 at 02:18:27PM +0100, Anton Khirnov wrote:
>>>>>>> Quoting James Almer (2021-11-13 13:22:12)
>>>>>>>> Also, missing docs.
>>>>>>>
>>>>>>> Could we add a development rule that all new filters need docs and
>>>> all
>>>>>>> new filters/codecs/(de)muxers need a test (unless special
>>>> circumstances,
>>>>>>> like hwaccel)?
>>>>>>
>>>>>> Iam in favor of this
>>>>>>
>>>>>>
>>>>> Against this, as experimental filters does not need docs,
>>>>
>>>> I strongly disagree, even experimental code needs docs. I often find it
>>>> good idea to write documentation _before_ writing the code.
>>>>
>>>> Besides, experimental filters do not belong in the main repository. Keep
>>>> them in your tree until stop being experimental.
>>>>
>>>
>>>
>>> Never, I will keep posting filters without docs on devel mailing list as
>> I
>>> wish.
>>
>> Even if you joke, nobody finds it funny, and it's annoying. So really,
>> stop already.
>>
> 
> Not joking, as explained to uneducated, sending patches without docs first
> time is OK.
> This is for testing ground approach. Off course not gonna push filter to
> git master without some kind of docs.

Ok, that's completely fine. But then why didn't you just said that the 
first time instead? Just saying "Will not write docs for the first 
draft, will do it for the final version" or similar would have prevented 
this entire thread.

> 
> 
>>
>>>
>>>
>>>>
>>>>> floats too.
>>>>
>>>> This is an excuse, we have ways of dealing with floats.
>>>>
>>>
>>> Citations needed.
>>>
>>>
>>>>
>>>> --
>>>> Anton Khirnov
>>>>
>>> _______________________________________________
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel at ffmpeg.org
>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>
>>> To unsubscribe, visit link above, or email
>>> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>>>
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>