[FFmpeg-devel] [PATCH] avfilter: add colorvd video filter

Anton Khirnov anton at khirnov.net
Fri Nov 19 16:04:35 EET 2021


Quoting Paul B Mahol (2021-11-19 14:55:42)
> On Fri, Nov 19, 2021 at 2:27 PM Michael Niedermayer <michael at niedermayer.cc>
> wrote:
> 
> > On Fri, Nov 19, 2021 at 02:18:27PM +0100, Anton Khirnov wrote:
> > > Quoting James Almer (2021-11-13 13:22:12)
> > > > Also, missing docs.
> > >
> > > Could we add a development rule that all new filters need docs and all
> > > new filters/codecs/(de)muxers need a test (unless special circumstances,
> > > like hwaccel)?
> >
> > Iam in favor of this
> >
> >
> Against this, as experimental filters does not need docs,

I strongly disagree, even experimental code needs docs. I often find it
good idea to write documentation _before_ writing the code.

Besides, experimental filters do not belong in the main repository. Keep
them in your tree until stop being experimental.

> floats too.

This is an excuse, we have ways of dealing with floats.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list