[FFmpeg-devel] [PATCH 1/4] fftools/cmdutils: Fix undefined 1 << 31

Michael Niedermayer michael at niedermayer.cc
Thu Nov 18 22:06:19 EET 2021


On Thu, Nov 18, 2021 at 10:07:36AM +0100, Andreas Rheinhardt wrote:
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> ---
>  fftools/cmdutils.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
> index 594eeef379..f80c361eba 100644
> --- a/fftools/cmdutils.c
> +++ b/fftools/cmdutils.c
> @@ -1823,7 +1823,7 @@ int show_sample_fmts(void *optctx, const char *opt, const char *arg)
>  int show_dispositions(void *optctx, const char *opt, const char *arg)
>  {
>      for (int i = 0; i < 32; i++) {
> -        const char *str = av_disposition_to_string(1 << i);
> +        const char *str = av_disposition_to_string(1U << i);

is it intended to have 1U<<31 cast to int and then checked as in
    if (disposition <= 0)
        return NULL;

 ?
 
[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If the United States is serious about tackling the national security threats 
related to an insecure 5G network, it needs to rethink the extent to which it
values corporate profits and government espionage over security.-Bruce Schneier
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20211118/2a23aa54/attachment.sig>


More information about the ffmpeg-devel mailing list