[FFmpeg-devel] [PATCH 8/9] ffmpeg: drop a useless assignment

Michael Niedermayer michael at niedermayer.cc
Tue Nov 16 15:46:43 EET 2021


On Mon, Nov 15, 2021 at 04:23:59PM +0100, Anton Khirnov wrote:
> bits_per_raw_sample is already set in new_video_stream(), so this code
> has no effect.
> ---
>  fftools/ffmpeg.c     | 7 -------
>  fftools/ffmpeg.h     | 1 -
>  fftools/ffmpeg_opt.c | 2 +-
>  3 files changed, 1 insertion(+), 9 deletions(-)

maybe i messed up or missing something but this breaks fate for me

TEST    lavf-pam
TEST    lavf-rgba.pam
TEST    lavf-gray.pam
TEST    lavf-gray16be.pam
TEST    lavf-rgb48be.pam
--- ./tests/ref/lavf/rgb48le.dpx	2021-11-01 13:29:46.883005610 +0100
+++ tests/data/fate/lavf-rgb48le.dpx	2021-11-16 14:34:59.063907946 +0100
@@ -1,3 +1,2 @@
-075963c3c08978b6a20555ba09161434 *tests/data/images/rgb48le.dpx/02.rgb48le.dpx
-tests/data/images/rgb48le.dpx/%02d.rgb48le.dpx CRC=0xe5b9c023
-609920 tests/data/images/rgb48le.dpx/02.rgb48le.dpx
+tests/data/images/rgb48le.dpx/%02d.rgb48le.dpx 
+
Test lavf-rgb48le.dpx failed. Look at tests/data/fate/lavf-rgb48le.dpx.err for details.
tests/Makefile:257: recipe for target 'fate-lavf-rgb48le.dpx' failed
make: *** [fate-lavf-rgb48le.dpx] Error 1
make: *** Waiting for unfinished jobs....
--- ./tests/ref/lavf/rgb48le_10.dpx	2021-11-01 13:29:46.883005610 +0100
+++ tests/data/fate/lavf-rgb48le_10.dpx	2021-11-16 14:34:59.075908062 +0100
@@ -1,3 +1,2 @@
-b9f22728f8ff393bf30cf6cbd624fa95 *tests/data/images/rgb48le_10.dpx/02.rgb48le_10.dpx
-tests/data/images/rgb48le_10.dpx/%02d.rgb48le_10.dpx CRC=0xf38d5830
-407168 tests/data/images/rgb48le_10.dpx/02.rgb48le_10.dpx
+tests/data/images/rgb48le_10.dpx/%02d.rgb48le_10.dpx 
+
Test lavf-rgb48le_10.dpx failed. Look at tests/data/fate/lavf-rgb48le_10.dpx.err for details.
tests/Makefile:257: recipe for target 'fate-lavf-rgb48le_10.dpx' failed
make: *** [fate-lavf-rgb48le_10.dpx] Error 1


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20211116/d62521a9/attachment.sig>


More information about the ffmpeg-devel mailing list