[FFmpeg-devel] [PATCH 05/15] lavc/videotoolbox: escape 0x00000[0-3]s in avcC PSs

Ridley Combs rcombs at rcombs.me
Tue Nov 16 05:30:17 EET 2021


> On Nov 15, 2021, at 09:25, Derek Buitenhuis <derek.buitenhuis at gmail.com> wrote:
> 
> On 11/13/2021 9:09 PM, rcombs wrote:
>> ---
>> libavcodec/videotoolbox.c | 51 +++++++++++++++++++++++++++++++++------
>> 1 file changed, 43 insertions(+), 8 deletions(-)
> 
> Why reimplement NAL emulation bytes for the Nth time in the codebase?

Because it was faster to write a trivial implementation than to track down an existing one. Even now that I've found a couple, one's a static in videotoolboxenc and is somewhat heavier than is warranted here, and one's in cbs_h2645 and is way heavier than is warranted. Any particular one in mind that I could use?

> 
> - Derek
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".



More information about the ffmpeg-devel mailing list