[FFmpeg-devel] [PATCH] ffmpeg: remove ffmpeg_videotoolbox

[Michael Niedermayer]

On Sat, Nov 13, 2021 at 03:41:29PM -0600, rcombs wrote:
> This was almost completely redundant. The only functionality that's no longer
> available after this removal is the videotoolbox_pixfmt arg, which has been
> obsolete for several years.
> ---
>  fftools/Makefile              |   4 -
>  fftools/ffmpeg.c              |  26 -----
>  fftools/ffmpeg.h              |  10 --
>  fftools/ffmpeg_opt.c          |  28 +----
>  fftools/ffmpeg_videotoolbox.c | 200 ----------------------------------
>  5 files changed, 4 insertions(+), 264 deletions(-)
>  delete mode 100644 fftools/ffmpeg_videotoolbox.c

This breaks fate, ive not look at why

make fate-sp5x
TEST    sp5x
--- ./tests/ref/fate/sp5x	2021-11-01 13:29:46.875005546 +0100
+++ tests/data/fate/sp5x	2021-11-14 15:29:41.747477728 +0100
@@ -9,22 +9,12 @@
 #sample_rate 1: 8000
 #channel_layout 1: 4
 #channel_layout_name 1: mono
-0,          0,          0,        1,   115200, 0x8ebcb7f8
 1,          0,          0,     1024,     2048, 0x366ee71c
-0,          1,          1,        1,   115200, 0x1fa8e673
 1,       1024,       1024,     1024,     2048, 0xc62f0414
-0,          2,          2,        1,   115200, 0xec07fb6a
 1,       2048,       2048,     1024,     2048, 0x754e0f19
-0,          3,          3,        1,   115200, 0x6773a8c3
 1,       3072,       3072,     1024,     2048, 0x4a44152a
-0,          4,          4,        1,   115200, 0x0d279643
 1,       4096,       4096,     1024,     2048, 0x4fd3ff01
-0,          5,          5,        1,   115200, 0xb33796e4
-0,          6,          6,        1,   115200, 0xfe11fc79
 1,       5120,       5120,     1024,     2048, 0x11c3fa1b
-0,          7,          7,        1,   115200, 0x4ac8e31b
 1,       6144,       6144,     1024,     2048, 0x9945fa06
-0,          8,          8,        1,   115200, 0x15317942
 1,       7168,       7168,     1024,     2048, 0x12e5071a
-0,          9,          9,        1,   115200, 0x07803f0e
 1,       8192,       8192,       22,       44, 0x7ad110e8
Test sp5x failed. Look at tests/data/fate/sp5x.err for details.
tests/Makefile:257: recipe for target 'fate-sp5x' failed
make: *** [fate-sp5x] Error 1


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20211114/49de19c3/attachment.sig>