[FFmpeg-devel] [PATCH 15/17] avformat/utils: Remove unused shorthand feature for auto-inserted BSF

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Tue Nov 9 20:01:53 EET 2021


Besides being unused it should not be used at all:
The order of options of bitstream filters is not guaranteed
to be stable at all.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
---
I wonder whether the undocumented and widely unknown shorthand stuff
in bsf.c should be removed as well.

 libavformat/utils.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/libavformat/utils.c b/libavformat/utils.c
index 509c0ecdce..b42f4d5ca0 100644
--- a/libavformat/utils.c
+++ b/libavformat/utils.c
@@ -1760,13 +1760,7 @@ int ff_stream_add_bitstream_filter(AVStream *st, const char *name, const char *a
     }
 
     if (args && bsfc->filter->priv_class) {
-        const AVOption *opt = av_opt_next(bsfc->priv_data, NULL);
-        const char * shorthand[2] = {NULL};
-
-        if (opt)
-            shorthand[0] = opt->name;
-
-        if ((ret = av_opt_set_from_string(bsfc->priv_data, args, shorthand, "=", ":")) < 0) {
+        if ((ret = av_set_options_string(bsfc->priv_data, args, "=", ":")) < 0) {
             av_bsf_free(&bsfc);
             return ret;
         }
-- 
2.30.2



More information about the ffmpeg-devel mailing list