[FFmpeg-devel] [PATCH 2/2] Fix missing PCM sample size option when it is used as the lone option for DirectShow audio capture

Roger Pack rogerdpack2 at gmail.com
Thu Nov 4 06:41:24 EET 2021


I have looked at these two patches and they look good to me, if
anybody could commit them for me, that would be great.

On Wed, Nov 3, 2021 at 8:10 PM Brad Isbell <brad at audiopump.co> wrote:
>
> From 25e34ef9f995afffe67e519bb6f03a750aa09ae2 Mon Sep 17 00:00:00 2001
> From: Brad Isbell <brad at audiopump.co>
> Date: Wed, 3 Nov 2021 20:38:59 -0500
> Subject: [PATCH 2/2] Fix missing PCM sample size option when it is used as
> the
>  lone option for DirectShow audio capture
>
> Signed-off-by: Brad Isbell <brad at audiopump.co>
> ---
>  libavdevice/dshow.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c
> index 5c1e494..e313c9a 100644
> --- a/libavdevice/dshow.c
> +++ b/libavdevice/dshow.c
> @@ -569,7 +569,7 @@ dshow_cycle_pins(AVFormatContext *avctx, enum
> dshowDeviceType devtype,
>                                                  (ctx->requested_width &&
> ctx->requested_height) ||
>                                                   ctx->pixel_format !=
> AV_PIX_FMT_NONE ||
>                                                   ctx->video_codec_id !=
> AV_CODEC_ID_RAWVIDEO))
> -                  || (devtype == AudioDevice && (ctx->channels ||
> ctx->sample_rate));
> +                  || (devtype == AudioDevice && (ctx->channels ||
> ctx->sample_rate || ctx->sample_size));
>      int format_set = 0;
>      int should_show_properties = (devtype == VideoDevice) ?
> ctx->show_video_device_dialog : ctx->show_audio_device_dialog;
>
> --
> 2.32.0.windows.1
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


More information about the ffmpeg-devel mailing list