[FFmpeg-devel] [PATCH v4 1/2] avcodec/libjxc: add JPEG XL decoding via libjxl

[Leo Izen]

On Tue, Nov 2, 2021 at 8:14 AM James Almer <jamrial at gmail.com> wrote:
> New entries must not change the value of other entries. You need to add
> it at the end of the list, or in this specific enum case, at the end of
> the section before the big offset jump, so immediately after
> AV_CODEC_ID_GEM.

Thanks, will change.

> If it's static then it doesn't need the ff_ prefix.
>
I thought that was optional. I'll remove ff_ from every static.

> Why are you adding a custom avoption named the same way as the global
> one? Just use avctx->threads.

I didn't know you could do that. Good to know. (I'm fairly new to this
particular part of the codebase.)

-Leo