[FFmpeg-devel] [PATCH] avfilter/yadif: Fix time base for large denominators

Andriy Gelman andriy.gelman at gmail.com
Tue May 25 05:33:41 EEST 2021


Hello,

On Mon, 24. May 11:52, Tom Boshoven wrote:
> This fixes an issue where the yadif filter could cause the timebase denominator to overflow.
> 
> Signed-off-by: Tom Boshoven <tom at jwplayer.com>
> ---
>  libavfilter/vf_yadif.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/libavfilter/vf_yadif.c b/libavfilter/vf_yadif.c
> index a6942a2aa2..b067c5eead 100644
> --- a/libavfilter/vf_yadif.c
> +++ b/libavfilter/vf_yadif.c
> @@ -293,8 +293,7 @@ static int config_output(AVFilterLink *outlink)
>      AVFilterContext *ctx = outlink->src;
>      YADIFContext *s = ctx->priv;
>  
> -    outlink->time_base.num = ctx->inputs[0]->time_base.num;
> -    outlink->time_base.den = ctx->inputs[0]->time_base.den * 2;
> +    outlink->time_base = av_mul_q(outlink->time_base, (AVRational){1, 2});
>      outlink->w             = ctx->inputs[0]->w;
>      outlink->h             = ctx->inputs[0]->h;

Some fate tests fail on patchwork:
https://patchwork.ffmpeg.org/project/ffmpeg/patch/20210524155206.47644-1-tom@jwplayer.com/

-- 
Andriy


More information about the ffmpeg-devel mailing list