[FFmpeg-devel] [PATCH 2/2] avio: do not export avpriv_io_{move, delete}

[Anton Khirnov]

Quoting Anton Khirnov (2020-01-13 11:33:01)
> Quoting Hendrik Leppkes (2020-01-10 23:40:37)
> > On Fri, Jan 10, 2020 at 7:31 PM James Almer <jamrial at gmail.com> wrote:
> > > Yes, i agree with this if we were talking about clearly marked
> > > non-public structs, fields and defines. In those cases, people using
> > > them should be aware of the consequences. But these are two five years
> > > old documented functions in a public header (Although admittedly not
> > > announced in APIChanges) and even featured in an API example tool.
> > > I don't think the avpriv_ prefix is something we documented outside of
> > > the developer guidelines, so anyone reading avio.h and the example will
> > > have no reason to think these were there by mistake.
> > >
> > > You could replace the doxy with a "do not use" notice aside from
> > > wrapping them in a scheduled removal preprocessor check, but at the very
> > > least the symbols should not be removed until the next major bump.
> > >
> > > If others agree with you though, I'll not block this.
> > >
> > 
> > If we plan to do a bump relatively soon anyway, then there is no
> > reason to really rush anything, and just let them in until such a time
> > that there is a bump. Considering their only not-really-public nature
> > we can forego the 2 year deprecation and just throw them out when we
> > open the ABI.
> 
> Ok, I can wait with this patch until the bump if it's going to happen
> soon.

pushed

-- 
Anton Khirnov