[FFmpeg-devel] [PATCH 3/3] avformat/avio: Check av_opt_copy() for failure

Michael Niedermayer michael at niedermayer.cc
Fri May 21 00:25:49 EEST 2021


Fixes: CID1477416 Unchecked return value

Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
 libavformat/avio.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/libavformat/avio.c b/libavformat/avio.c
index 2974f4b2b4..6be6f9bf97 100644
--- a/libavformat/avio.c
+++ b/libavformat/avio.c
@@ -313,8 +313,11 @@ int ffurl_open_whitelist(URLContext **puc, const char *filename, int flags,
     int ret = ffurl_alloc(puc, filename, flags, int_cb);
     if (ret < 0)
         return ret;
-    if (parent)
-        av_opt_copy(*puc, parent);
+    if (parent) {
+        ret = av_opt_copy(*puc, parent);
+        if (ret < 0)
+            goto fail;
+    }
     if (options &&
         (ret = av_opt_set_dict(*puc, options)) < 0)
         goto fail;
-- 
2.17.1



More information about the ffmpeg-devel mailing list