[FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

Michael Fabian 'Xaymar' Dirks michael.dirks at xaymar.com
Thu May 20 21:06:49 EEST 2021


On 2021-05-20 19:59, Nicolas George wrote:
> Michael Fabian 'Xaymar' Dirks (12021-05-20):
>> The issue can't be fixed
> Then you should not be hiding the warning. It means something.
I was asked to fix or remove it. Removing it breaks Matroska files entirely. Fixing it is not possible. What other option do I have when I'm not in control of the Matroska specification, yet somehow am supposed to fix the Matroska specification? I'm confused.
> I have yet to see a convincing explanation of a case where 1µs would not
> be enough, by the way. AFAICS, the issue is mostly people handling
> rounding incorrectly; changing the time base would not fix the code that
> does improper rounding, it will just let the rounding errors accumulate
> slower. Fix the code, and there will be no more rounding errors.
The default precision for Matroska is 1ms not 1µs. 1µs is plenty enough, but 1ms is not.

-- 
Sincerely | Mit freundlichen Grüßen

Michael Fabian 'Xaymar' Dirks
Software Designer & Engineer



More information about the ffmpeg-devel mailing list