[FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: #define TARGET_CPU_ARM64 to 0 if not provided by the SDK

Zane van Iperen zane at zanevaniperen.com
Sun May 16 00:56:26 EEST 2021



On 16/5/21 12:57 am, Carl Eugen Hoyos wrote:

>>>> --- a/libavcodec/videotoolboxenc.c
>>>> +++ b/libavcodec/videotoolboxenc.c
>>>> @@ -50,6 +50,11 @@ enum { kCVPixelFormatType_420YpCbCr10BiPlanarFullRange = 'xf20' };
>>>>    enum { kCVPixelFormatType_420YpCbCr10BiPlanarVideoRange = 'x420' };
>>>>    #endif
>>>> +/* Older SDKs don't have this, make sure we can actually compile we're using one. */
>>> Second half of that sentence is missing a word or has too many.
>>
>> Yeah, picked that up shortly after I posted it. It's meant to read:
>> "Older SDKs don't have this, make sure we can actually compile if we're using one."
> 
> Make it „Defined in macOS 10.x“ instead or remove the comment.
> 

I'll remove it, it's self-explanatory anyway.


More information about the ffmpeg-devel mailing list