[FFmpeg-devel] [PATCHv3] fate/integer.c: Connect test to fuzzer

Michael Niedermayer michael at niedermayer.cc
Mon May 10 18:26:19 EEST 2021


On Fri, May 07, 2021 at 09:23:09PM +0530, Vedaa wrote:
> Hi,
> 
> I have added the inclusion guards and changed the author. 
> 
[...]
> @@ -0,0 +1,45 @@
> +/*
> + * Copyright (c) 2004 Michael Niedermayer <michaelni at gmx.at>
> + *
> + * This file is part of FFmpeg.
> + *
> + * FFmpeg is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * FFmpeg is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with FFmpeg; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> + */
> +#ifndef AVUTIL_TEST_INTEGER_H
> +#define AVUTIL_TEST_INTEGER_H

this should have been testS to match the directory




[...]
> +#include <libavutil/tests/integer.h>
> +#include <libavutil/intreadwrite.h>

i assume the existing fuzzer targets use the correct #include type 
this is using the wrong then

ive changed these trvial things and will apply the patch
next step is to update the google oss-fuzz side to have this hooked up
please submit the changes for that to googles github as a pull request,
i cannot help with that side though as i have no special powers on the
oss-fuzz git

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

During times of universal deceit, telling the truth becomes a
revolutionary act. -- George Orwell
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210510/26099a07/attachment.sig>


More information about the ffmpeg-devel mailing list