[FFmpeg-devel] [PATCH 3/5 v2] avformat: move AVStream.{parser, need_parsing} to AVStreamInternal

James Almer jamrial at gmail.com
Thu May 6 21:47:13 EEST 2021


On 5/6/2021 3:31 PM, Andreas Rheinhardt wrote:
> James Almer:
>> Those are private fields, no reason to have them exposed in a public
>> header.
>>
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>> Now also porting the v4l2 outdev, which unfortunately requires an accessor.
>> If anyone with a v4l2 capable machine wants to check if not setting
>> need_parsing at all for h264 streams is an option, that'd be better.
>>
> 
> Alternatively one could just move needs_parsing to the beginning of
> AVStreamInternal.

That still ties the contents of AVStreamInternal to the ABI, even if a 
single field at the beginning, and the plan is to replace the 
AVCodecParserContext API altogether, which may include removing this 
field or even changing its semantics.

Once any change takes place, avpriv_stream_set_need_parsing() can be 
made into a no-op, or made to set a different field converting 
AVStreamParseType values as required.


More information about the ffmpeg-devel mailing list