[FFmpeg-devel] [PATCH 4/5] libavcodec: write out user data unregistered SEI for nvenc

Timo Rothenpieler timo at rothenpieler.org
Sat May 1 02:38:52 EEST 2021


On 01.05.2021 01:30, Brad Hards wrote:
> I don't understand this comment. The existing code defines a fixed size 
array,
> and I don't want to change it because I couldn't find an authoritative source
> as to why that size or approach. I assume it could be a hardware limitation on
> at least some versions.
> So I've tried to follow the existing approach, and ensure that the loop 
never
> exceeds the available space by tracking the count.
> Am I missing something?

Pretty sure the 8 is just an arbitrary number picked when originally 
writing this code.
It now no longer seems appropriate, so a dynamic array might be in order.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4494 bytes
Desc: S/MIME Cryptographic Signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210501/5cde3664/attachment.bin>


More information about the ffmpeg-devel mailing list