[FFmpeg-devel] [PATCH 1/2] fftools/ffprobe: Add missing dispositions

[Marton Balint]

On Tue, 30 Mar 2021, Andreas Rheinhardt wrote:

> Andreas Rheinhardt:
>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
>> ---

>> diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
>> index 11e3cbd6c2..38462e1ff3 100644
>> --- a/fftools/ffprobe.c
>> +++ b/fftools/ffprobe.c
>> @@ -2770,6 +2770,11 @@ static int show_stream(WriterContext *w, AVFormatContext *fmt_ctx, int stream_id
>>          PRINT_DISPOSITION(CLEAN_EFFECTS,    "clean_effects");
>>          PRINT_DISPOSITION(ATTACHED_PIC,     "attached_pic");
>>          PRINT_DISPOSITION(TIMED_THUMBNAILS, "timed_thumbnails");
>> +        PRINT_DISPOSITION(CAPTIONS,         "captions");
>> +        PRINT_DISPOSITION(DESCRIPTIONS,     "descriptions");
>> +        PRINT_DISPOSITION(METADATA,         "metadata");
>> +        PRINT_DISPOSITION(DEPENDENT,        "dependent");
>> +        PRINT_DISPOSITION(STILL_IMAGE,      "still_image");
>>          writer_print_section_footer(w);
>>      }
>>

> Will apply this patchset tomorrow unless there are objections.

Please update doc/ffprobe.xsd accordingly!

I wonder if a fate test testing the XML output of ffprobe can be extended 
to do a validation of the XML via the XSD so this does not gets 
forgatten...

Thanks,
Marton