[FFmpeg-devel] [PATCH 1/6] avcodec/h264_slice: Check input SPS in ff_h264_update_thread_context()

[Hendrik Leppkes]

On Mon, Mar 22, 2021 at 10:05 PM Michael Niedermayer
<michael at niedermayer.cc> wrote:
>
> Fixes: crash
> Fixes: check_pkt.mp4
>
> Found-by: Rafael Dutra <rafael.dutra at cispa.de>
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavcodec/h264_slice.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c
> index 14b945756b..910d8b8848 100644
> --- a/libavcodec/h264_slice.c
> +++ b/libavcodec/h264_slice.c
> @@ -304,9 +304,8 @@ int ff_h264_update_thread_context(AVCodecContext *dst,
>      if (dst == src)
>          return 0;
>
> -    // We can't fail if SPS isn't set at it breaks current skip_frame code
> -    //if (!h1->ps.sps)
> -    //    return AVERROR_INVALIDDATA;
> +    if (inited && !h1->ps.sps)
> +        return AVERROR_INVALIDDATA;
>

Any considerations for the removed comment?

- Hendrik