[FFmpeg-devel] [PATCH 1/2] avformat/mov: Fix extended atom size buffer length check

[Derek Buitenhuis]

On 18/03/2021 16:14, Derek Buitenhuis wrote:
> When extended atom size support was added to probing in
> fec4a2d232d7ebf6d1084fb568d4d84844f25abc, the buffer
> size check was backwards, but probing continued to work
> because there was no minimum size check yet, so despite
> size being 1 on these atoms, and failing to read the 64-bit
> size, the tag was still correctly read.
> 
> When 0b78016b2d7c36b32d07669c0c86bc4b4225ec98 introduced a
> minimum size check, this exposed the bug, and broke probing
> any files with extended atom sizes, such as entirely valid
> large files that start whith mdat atoms.
> 
> Signed-off-by: Derek Buitenhuis <derek.buitenhuis at gmail.com>
> ---
>  libavformat/mov.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I synced the FATE sample and will push these a little later today unless there are comments.

- Derek