[FFmpeg-devel] Re: [PATCH 01/48] avcodec/packet: deprecate av_init_packet()

Anton Khirnov anton at khirnov.net
Sun Mar 21 14:28:35 EET 2021


Quoting James Almer (2021-03-05 17:32:52)
> diff --git a/libavformat/avformat.h b/libavformat/avformat.h
> index 7da2f3d98e..783cc1b591 100644
> --- a/libavformat/avformat.h
> +++ b/libavformat/avformat.h
> @@ -954,7 +954,11 @@ typedef struct AVStream {
>       * decoding: set by libavformat, must not be modified by the caller.
>       * encoding: unused
>       */
> +#if FF_API_INIT_PACKET
>      AVPacket attached_pic;
> +#else
> +    AVPacket *attached_pic;
> +#endif

Sorry I'm late to the party, but as we are changing the type of an
existing field, we need to explicitly spell out a way for the callers to
make their code forward compatible. E.g. similarly to what I made for
thread_safe_callbacks deprecation.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list