[FFmpeg-devel] [PATCH v3] avcodec: add Actimagine VX video decoder

[Florian Nouwt]

Andreas Rheinhardt:

- Why are these tables not internal to actimagine_vx.c?

I separated the data because for parsing the vx container files I will
need a parser, which will be in a separate file from the decoder and
requires those tables.

- You wasted an opportunity to add a space before '=' (this code is
old and does not match the currently preferred style).

Just to have it clear, when it comes to the tables, is the preferred
style with the brace on the next line or on the same line? And am I
supposed to fix all style errors in that file?

- In case the actimagine_vx decoder is disabled and only the H.264
decoder is enabled (I expect this to happen for lots of slim builds),
one does not need to use an ff_thread_once() here at all, because
ff_h264_decode_init_vlc is already guarded this way. Can you add
compile-time checks for this?

It would remove some safety ofc. But I guess I can put a comment in
the header file that tells any potential future people that might use
it to not forget to change it.

Zane van Iperen:
Should I submit that as a separate patch then after the current one
minus that change has been accepted? Without that change it's
impossible to test the decoder.