[FFmpeg-devel] [PATCH] avcodec/dv_profile: PAL DV files with dsf flag 0 - detect via pal flag and buf_size

[Mark Plomer]

Okay cool, I added the check for the PAL flag - this still works fine 
for my test-videos.

I also looked at the old hack above with the codec_tag check - changed 
in 2013 for ticket #2177 (patch by Michael Niedermayer). I removed that 
more specific hack and the test-video attached to ticket #2177 also runs 
into the new hack now ... and still works fine. It also has a "dsf = 0" 
flag, though it is PAL.

So it was really a good idea to consolidate those hacks! Maybe the whole 
generic matching logic should be refactored, to match against the pal 
flag instead of the dsf flag? (The "buf_size" check may also be obsolete 
then). But this will be another task ;-)

I attached the updated patch.

Regards
Mark

Am 16.03.21 um 23:12 schrieb Marton Balint:
>
>> Then at least check the 50/60 flag as well in the VAUX source pack, 
>> e.g.:
>>
>> pal   = !!(frame[80 * 5 + 48 + 3] & 0x20);
>
> And as far as I see, the more specific hack checking for codec_tag and 
> similar can be removed then, because your check covers that case as well.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-avcodec-dv_profile-PAL-DV-files-with-dsf-flag-0.patch
Type: text/x-patch
Size: 2091 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210318/600a2d9b/attachment.bin>