[FFmpeg-devel] [PATCH 1/2] avutil/common: Add FFINCREASE_PTR()

[Michael Niedermayer]

On Sat, Mar 13, 2021 at 10:20:37PM +0100, Michael Niedermayer wrote:
> On Sat, Mar 13, 2021 at 04:41:39PM +0100, Lynne wrote:
> > Mar 13, 2021, 16:18 by michael at niedermayer.cc:
> > 
> > > On Fri, Feb 19, 2021 at 10:00:39PM +0100, Andreas Rheinhardt wrote:
> > >
> > >> Michael Niedermayer:
> > >> > Suggested-by: Andreas Rheinhardt
> > >> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > >> > ---
> > >> >  doc/APIchanges     | 3 +++
> > >> >  libavutil/common.h | 2 ++
> > >> >  2 files changed, 5 insertions(+)
> > >> > 
> > >> > diff --git a/doc/APIchanges b/doc/APIchanges
> > >> > index c353d2d281..e38a5cb91c 100644
> > >> > --- a/doc/APIchanges
> > >> > +++ b/doc/APIchanges
> > >> > @@ -15,6 +15,9 @@ libavutil:     2017-10-21
> > >> > 
> > >> >  API changes, most recent first:
> > >> > 
> > >> > +2021-02-xx - xxxxxxxxxx - lavu 57.xx.100 - common.h
> > >> > +  Add FFINCREASE_PTR()
> > >> > +
> > >> >  2021-02-14 - xxxxxxxxxx - lavd 58.12.100 - avdevice.h
> > >> >    Deprecated avdevice_capabilities_create() and
> > >> >    avdevice_capabilities_free().
> > >> > diff --git a/libavutil/common.h b/libavutil/common.h
> > >> > index aee353d399..bf35bc8507 100644
> > >> > --- a/libavutil/common.h
> > >> > +++ b/libavutil/common.h
> > >> > @@ -108,6 +108,8 @@
> > >> >  #define FFSWAP(type,a,b) do{type SWAP_tmp= b; b= a; a= SWAP_tmp;}while(0)
> > >> >  #define FF_ARRAY_ELEMS(a) (sizeof(a) / sizeof((a)[0]))
> > >> > 
> > >> > +#define FFINCREASE_PTR(ptr, off) ((off) ? (ptr) + (off) : (ptr))
> > >> > +
> > >> >  /* misc math functions */
> > >> > 
> > >> >  #ifdef HAVE_AV_CONFIG_H
> > >> > 
> > >> If this is intended to be a public macro, it should have a proper AV prefix.
> > >>
> > >
> > > will apply with AV prefix
> > >
> > 
> > Could we not make it public? Macros like FF_ARRAY_ELEMS aren't,
> > and I think this is one of those utility functions that API users probably
> > won't find useful.
> 
> > Plus the name is kinda long.
> 
> would you prefer FF_PTR_ADD() ?

will submit a patch with that and without adding it to APIchanges



[...]


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210315/64c5ce8f/attachment.sig>