[FFmpeg-devel] [PATCH] avcodec/dv_profile: dv files with wrong dsf flag - detect via buf_size

[Michael Niedermayer]

On Sat, Jan 16, 2021 at 02:40:03PM +0100, Mark Plomer wrote:
> Trying to fix https://trac.ffmpeg.org/ticket/8333
> 
> Some of my old DV AVI files have the DSF-Flag of frames set to 0, although
> it is PAL (I think they were rendered with Ulead Media Studio Pro) ... this
> causes ffmpeg/VLC-player to produce/play corrupted video.
> 
> In other players/editors it works fine including:
> 
> - VirtualDub
> - Windows Media Player
> - AVCutty
> - Ulead Media Studio Pro (very old)
> 
> I had a look at VirtualDub ... there the PAL/NTSC detection is based on the
> frame rate from AVISTREAMINFO header (dwRate/dwScale) - see https://github.com/Pavuucek/VirtualDub/blob/f47ebd2536f0034b048180d0b9cb9bde0ab10c73/src/VirtualDub/source/VideoSource.cpp#L1211
> 
> As I don't know, how to access the AVI header info inside
> dvvideo_decode_frame()/ff_dv_frame_profile(), I tried another workaround by
> checking the buf_size against the dv_profile.
> 
> It works fine now, but I don't know, if this is really the best solution ...
> 

>  dv_profile.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 9676b11bedef27c1c2a359c7617ecc6d30044b16  0001-avcodec-dv_profile-dv-files-with-wrong-dsf-flag.patch
> From 9dd240e6700c28601014e79e55d3ddee5f6b13c7 Mon Sep 17 00:00:00 2001
> From: Mark Plomer <not-implemented at mark-plomer.de>
> Date: Sat, 16 Jan 2021 14:04:44 +0100
> Subject: [PATCH] avcodec/dv_profile: dv files with wrong dsf flag - detect via
>  buf_size
> 
> ---

The commit message should mention "Fixes Ticket8333" if that is a bugfix 
for that ticket

also maybe some of the other details you write in your mail could be moved
into the commit message

Thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210313/bf4facde/attachment.sig>