[FFmpeg-devel] [PATCH 9/9] avcodec/cbs_h26[45]: Remove redundant enum constants

Mark Thompson sw at jkqxz.net
Sat Mar 13 00:20:08 EET 2021


On 10/03/2021 10:29, Andreas Rheinhardt wrote:
> Unused since 8843607f495c95c1e67a3ce3d6f15dca6e252439.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> ---
>   libavcodec/cbs_h264.h | 10 ----------
>   libavcodec/cbs_h265.h |  9 ---------
>   2 files changed, 19 deletions(-)
> 
> diff --git a/libavcodec/cbs_h264.h b/libavcodec/cbs_h264.h
> index 9eb97eae24..5a8641a333 100644
> --- a/libavcodec/cbs_h264.h
> +++ b/libavcodec/cbs_h264.h
> @@ -28,16 +28,6 @@
>   #include "h264.h"
>   
>   
> -enum {
> -    // This limit is arbitrary - it is sufficient for one message of each
> -    // type plus some repeats, and will therefore easily cover all sane
> -    // streams.  However, it is possible to make technically-valid streams
> -    // for which it will fail (for example, by including a large number of
> -    // user-data-unregistered messages).
> -    H264_MAX_SEI_PAYLOADS = 64,
> -};
> -
> -
>   typedef struct H264RawNALUnitHeader {
>       uint8_t nal_ref_idc;
>       uint8_t nal_unit_type;
> diff --git a/libavcodec/cbs_h265.h b/libavcodec/cbs_h265.h
> index 738cbeec2c..f7753f1206 100644
> --- a/libavcodec/cbs_h265.h
> +++ b/libavcodec/cbs_h265.h
> @@ -26,15 +26,6 @@
>   #include "cbs_sei.h"
>   #include "hevc.h"
>   
> -enum {
> -    // This limit is arbitrary - it is sufficient for one message of each
> -    // type plus some repeats, and will therefore easily cover all sane
> -    // streams.  However, it is possible to make technically-valid streams
> -    // for which it will fail (for example, by including a large number of
> -    // user-data-unregistered messages).
> -    H265_MAX_SEI_PAYLOADS = 64,
> -};
> -
>   typedef struct H265RawNALUnitHeader {
>       uint8_t nal_unit_type;
>       uint8_t nuh_layer_id;
> 

Yes, LGTM.

Thanks,

- Mark


More information about the ffmpeg-devel mailing list