[FFmpeg-devel] [PATCH 2/2] avfilter/vf_uspp: Fix leak of packet side data

Michael Niedermayer michael at niedermayer.cc
Fri Mar 12 19:24:20 EET 2021


On Fri, Mar 12, 2021 at 03:24:07PM +0100, Andreas Rheinhardt wrote:
> The uspp filter uses a special option ("no_bitstream") of
> the Snow encoder to suppress it from generating output.
> The filter therefore did not unref the packet after usage,
> believing it to be blank. But this is wrong, as the Snow encoder
> attaches quality stats side data to the packet.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> ---

LGTM


> If there were a fate test for this filter, this would have been found
> and fixed long ago.



[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210312/a1c73d57/attachment.sig>


More information about the ffmpeg-devel mailing list