[FFmpeg-devel] [PATCH 1/2] avfilter/vf_uspp: Fix leak of qp-table on error

Andreas Rheinhardt andreas.rheinhardt at gmail.com
Fri Mar 12 16:24:06 EET 2021


Fixes Coverity issue #1473500.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
---
Why does the new qp API actually need to allocate the qp table (instead
of reusing the side-data qp)?

 libavfilter/vf_uspp.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavfilter/vf_uspp.c b/libavfilter/vf_uspp.c
index 8b39f53c3d..b77edeb244 100644
--- a/libavfilter/vf_uspp.c
+++ b/libavfilter/vf_uspp.c
@@ -425,6 +425,8 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *in)
                 out = ff_get_video_buffer(outlink, aligned_w, aligned_h);
                 if (!out) {
                     av_frame_free(&in);
+                    if (qp_table != uspp->non_b_qp_table)
+                        av_free(qp_table);
                     return AVERROR(ENOMEM);
                 }
                 av_frame_copy_props(out, in);
-- 
2.27.0



More information about the ffmpeg-devel mailing list