[FFmpeg-devel] [PATCH] lavu: add VKAPI hwcontext implementation

Lynne dev at lynne.ee
Fri Mar 12 04:32:42 EET 2021


Mar 12, 2021, 02:04 by suji.velupillai at broadcom.com:

> Thank you for the review, please see inline.
>
> On Thu, Mar 11, 2021 at 2:56 PM Lynne <dev at lynne.ee> wrote:
>
>> > +    /**
>> > +     * Convert AVPixelFormat to VKAPI equivalent pixel format
>> > +     */
>> > +    int (*av2vk_fmt)(enum AVPixelFormat pixel_format);
>> >
>>
>> This function can stay, but it needs no state at all, so just put
>> it out side of the structure. Name it:
>> const VkFormat *av_vkil_from_pixfmt(enum AVPixelFormat p);
>> The *vk* namespace is taken by Vulkan already.
>>
>
> Make sense, can I change it to vkapi instead to be consistent?
>

What about expanding "vk" shortenings to "valkyrie" instead?
vkapi is kinda really close to meaning vulkan api -_-


More information about the ffmpeg-devel mailing list