[FFmpeg-devel] [PATCH 11/23] dnn/dnn_backend_native: Fix leak in case parsing options fails

[Guo, Yejun]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Andreas Rheinhardt
> Sent: 2021年3月11日 5:55
> To: ffmpeg-devel at ffmpeg.org
> Cc: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> Subject: [FFmpeg-devel] [PATCH 11/23] dnn/dnn_backend_native: Fix leak in
> case parsing options fails
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> ---
>  libavfilter/dnn/dnn_backend_native.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavfilter/dnn/dnn_backend_native.c
> b/libavfilter/dnn/dnn_backend_native.c
> index 5336cd765a..fd1f9e299d 100644
> --- a/libavfilter/dnn/dnn_backend_native.c
> +++ b/libavfilter/dnn/dnn_backend_native.c
> @@ -157,12 +157,12 @@ DNNModel *ff_dnn_load_model_native(const char
> *model_filename, DNNFunctionType f
>      if (!native_model){
>          goto fail;
>      }
> +    model->model = native_model;
> 
>      native_model->ctx.class = &dnn_native_class;
>      model->options = options;
>      if (av_opt_set_from_string(&native_model->ctx, model->options, NULL,
> "=", "&") < 0)
>          goto fail;
> -    model->model = (void *)native_model;

nice catch, thanks, LGTM.