[FFmpeg-devel] [PATCH] avcodec/gifenc: Actually use the shrunk palette

Derek Buitenhuis derek.buitenhuis at gmail.com
Wed Mar 10 17:20:55 EET 2021


I have no idea how nobody, including myself, noticed this.

Signed-off-by: Derek Buitenhuis <derek.buitenhuis at gmail.com>
---
 libavcodec/gif.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/libavcodec/gif.c b/libavcodec/gif.c
index 938bc0e928..cafd93e190 100644
--- a/libavcodec/gif.c
+++ b/libavcodec/gif.c
@@ -383,13 +383,12 @@ static int gif_image_write_image(AVCodecContext *avctx,
     bytestream_put_le16(bytestream, height);
 
     if (palette || !s->use_global_palette) {
-        const uint32_t *pal = palette ? palette : s->palette;
         unsigned pow2_count = av_log2(shrunk_palette_count - 1);
         unsigned i;
 
         bytestream_put_byte(bytestream, 1<<7 | pow2_count); /* flags */
         for (i = 0; i < 1 << (pow2_count + 1); i++) {
-            const uint32_t v = pal[i];
+            const uint32_t v = shrunk_palette[i];
             bytestream_put_be24(bytestream, v);
         }
     } else {
-- 
2.30.0



More information about the ffmpeg-devel mailing list