[FFmpeg-devel] [PATCH] lavfi: add a libplacebo filter

[James Almer]

On 3/9/2021 1:38 PM, Niklas Haas wrote:
> +    if (s->skip_av1_grain)
> +        image.av1_grain = (struct pl_av1_grain_data) {0};

[...]

> +    if (!s->skip_av1_grain)
> +        av_frame_remove_side_data(out, AV_FRAME_DATA_FILM_GRAIN_PARAMS);

[...]

> +    { "skip_av1_grain", "Disable AV1 grain application", OFFSET(skip_av1_grain), AV_OPT_TYPE_BOOL, {.i64 = 0}, 0, 1, DYNAMIC },

How does this work? Does pl_upload_avframe() support parsing the 
filmgrain side data? If so, that's pretty cool.

Also, I'd prefer if this was inverted. So make it filmgrain or maybe 
apply_filmgrain, and of course set it to 1 by default. And it doesn't 
need to specify it's for AV1 since the AV_FRAME_DATA_FILM_GRAIN_PARAMS 
side data type could be extended to support the H.274 implementation in 
the future.