[FFmpeg-devel] [PATCH]lavf/sga: Fix several format specifiers

[Paul B Mahol]

On Mon, Mar 8, 2021 at 9:22 AM Anton Khirnov <anton at khirnov.net> wrote:

> Quoting Carl Eugen Hoyos (2021-03-04 22:47:57)
> > Am Do., 4. März 2021 um 22:23 Uhr schrieb Moritz Barsnick <
> barsnick at gmx.net>:
> > >
> > > On Thu, Mar 04, 2021 at 20:37:26 +0100, Carl Eugen Hoyos wrote:
> > > > attached patch fixes a few warnings when compiling for 32bit.
> > >
> > > >      av_log(s, AV_LOG_DEBUG, "START %s\n", where);
> > > > -    av_log(s, AV_LOG_DEBUG, "pos: %lX\n", avio_tell(s->pb));
> > > > +    av_log(s, AV_LOG_DEBUG, "pos: %"PRIX64"\n", avio_tell(s->pb));
> > >
> > > #include <inttypes.h>
> >
> > It is included through common.h - do we add it to every C file
> > that would need it if common.h were not included?
>
> Yes, every file should explicitly include all the headers it directly
> uses. There was a recent discussion about this.
>

That would make bunch of headers needed to be added to every single file.

I do not remember such discussion ever take place.


> --
> Anton Khirnov
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".