[FFmpeg-devel] [PATCH] fftools/ffplay: do not write out of rdft visualization texture

Michael Niedermayer michael at niedermayer.cc
Mon Mar 8 00:28:18 EET 2021


On Wed, Mar 03, 2021 at 11:27:22PM +0100, Marton Balint wrote:
> If the window is resized it was possible that xpos pointed outside the
> visualization texture. By rearranging the overflow check we make sure this (and
> a crash) does not happen.
> 

> We also don't have to use xleft for start position, as that is 0 anyways, and
> if we ever want to take into account xleft then the texture should be
> positioned accordingly when rendering.

reading this, i wonder if a assertion with xleft == 0 would make sense 

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210307/9fedbe14/attachment.sig>


More information about the ffmpeg-devel mailing list