[FFmpeg-devel] [PATCH] avformat/http: Fix leak when using deprecated option

[Marton Balint]

On Sat, 6 Mar 2021, Andreas Rheinhardt wrote:

> Marton Balint:
>> 
>> 
>> On Sat, 6 Mar 2021, Andreas Rheinhardt wrote:
>> 
>>> When the deprecated option "user-agent" was set to something different
>>> than its default value, said option would always precede and overwrite
>>> the ordinary user_agent option (regardless of whether it was explicitly
>>> set) which leads to a leak of the user_agent option (which has a default
>>> value, so the leak happens always).
>>> Fix this by setting the same destination for both options; the last
>>> option applied wins then.
>> 
>> I think you should simply remove the old option. AFAIK public options
>> are not considered part of API/ABI, therefore after the deprecation
>> period of at least 2 years they can be removed anytime. I am not sure
>> why a deprecation guard was added for this removal.
>> 
> But I think I need to apply this anyway in order to have something to
> backport (I don't think we remove options from old releases).

Yeah, that is true.

Thanks,
Marton