[FFmpeg-devel] [PATCH V4 2/4] libavfilter/buffersink.c: unref private_ref when frame leaves libavfilter

Anton Khirnov anton at khirnov.net
Thu Mar 4 11:45:01 EET 2021


Quoting Guo, Yejun (2021-03-04 09:48:14)
> Hi, I think option 2 might be the good choice for now.

Given past experience, I am very much not a fan of "for now" solutions.
They tend to ossify and remain in place for years (I have seen at least
one "//temporary hack" remain unchanged for over 10 years). Then further
hacks are grown on these "for now" solutions and they become very hard
to change or remove.

So I would strongly prefer that you spend the effort now to design a
proper future-proof solution (most likely side data based). If it turns
out to need some change later, then there's plenty of precedent for
changing API.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list