[FFmpeg-devel] [PATCH] avutil/hwcontext: add support to allow hardware to ref/unref frame

Hendrik Leppkes h.leppkes at gmail.com
Thu Mar 4 10:06:17 EET 2021


On Thu, Mar 4, 2021 at 7:20 AM <suji.velupillai at broadcom.com> wrote:
>
> From: Patrick Rault <patrick.rault at broadcom.com>
>
> Add support to allow attached hardware to add/remove reference to the
> frame buffer mirroring the ffmpeg.
>
> Signed-off-by: Patrick Rault <patrick.rault at broadcom.com>
> Signed-off-by: Suji Velupillai <suji.velupillai at broadcom.com>

New API additions should include an explanation of which problems this
solves, how it should be used, and why it is necessary. Otherwise we
have no reference to even judge the usefulness of such an API.

Looking at the patch, the change to av_frame_ref looks fishy to me.
Why would dst reference itself, and not src?

- Hendrik


More information about the ffmpeg-devel mailing list