[FFmpeg-devel] [PATCH 3/4] avformat/dcstr: Check sample rate

Michael Niedermayer michael at niedermayer.cc
Wed Mar 3 11:49:03 EET 2021


Fixes: signed integer overflow: -1300248894420254720 * 16 cannot be represented in type 'long'
Fixes: 30879/clusterfuzz-testcase-minimized-ffmpeg_dem_DCSTR_fuzzer-5094464215449600

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
 libavformat/dcstr.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavformat/dcstr.c b/libavformat/dcstr.c
index 9041a86539..1233baaf7e 100644
--- a/libavformat/dcstr.c
+++ b/libavformat/dcstr.c
@@ -43,6 +43,8 @@ static int dcstr_read_header(AVFormatContext *s)
     st->codecpar->codec_type  = AVMEDIA_TYPE_AUDIO;
     st->codecpar->channels    = avio_rl32(s->pb);
     st->codecpar->sample_rate = avio_rl32(s->pb);
+    if (st->codecpar->sample_rate < 0)
+        return AVERROR_INVALIDDATA;
     codec                  = avio_rl32(s->pb);
     align                  = avio_rl32(s->pb);
     avio_skip(s->pb, 4);
-- 
2.17.1



More information about the ffmpeg-devel mailing list