[FFmpeg-devel] [PATCH] Bugfix for #9135

James Almer jamrial at gmail.com
Tue Mar 2 18:56:34 EET 2021


On 3/2/2021 1:25 PM, Peter White wrote:
> Sorry, apparently patches need to be sent inline, I just noticed. Please 
> excuse my ignorance.

They don't need to be inline, although it is preferred. What they need 
to be is made with git format-patch, which preserves authorship 
information and commit message.

Also, the commit message should be descriptive of what it fixes, and not 
only reference a ticket number.

> 
> Peter
> 
> 
> diff --git a/configure b/configure
> index d11942fced..bcc845668b 100755
> --- a/configure
> +++ b/configure
> @@ -6490,7 +6490,7 @@ enabled mmal              && { check_lib mmal 
> interface/mmal/mmal.h mmal_port_co
>                                  die "ERROR: mmal not found" &&
>                                  check_func_headers 
> interface/mmal/mmal.h "MMAL_PARAMETER_VIDEO_MAX_NUM_CALLBACKS"; }
>   enabled openal            && { { for al_extralibs in "${OPENAL_LIBS}" 
> "-lopenal" "-lOpenAL32"; do
> -                               check_lib openal 'AL/al.h' alGetError 
> "${al_extralibs}" && break; done } ||
> +                               check_lib openal 'AL/al.h' alGetError 
> "${al_extralibs}" && break; done; } ||
>                                  die "ERROR: openal not found"; } &&
>                                { test_cpp_condition "AL/al.h" 
> "defined(AL_VERSION_1_1)" ||
>                                  die "ERROR: openal must be installed 
> and version must be 1.1 or compatible"; }
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".



More information about the ffmpeg-devel mailing list