[FFmpeg-devel] [PATCH V4 2/4] libavfilter/buffersink.c: unref private_ref when frame leaves libavfilter

[Paul B Mahol]

Just use frame metadata.

On Mon, Mar 1, 2021 at 3:24 PM Nicolas George <george at nsup.org> wrote:

> Guo, Yejun (12021-03-01):
> > Thanks for the review, as we talked at
> http://ffmpeg.org/pipermail/ffmpeg-devel/2021-February/276728.html,
> > private_ref is allocated in filter vf_dnn_detect.c for detected results,
> and other
> > filters such as vf_drawbox/text (in plan) will read it.
> >
> > Since private_ref is for a single libav* library, it has to be NULL when
> it leaves libavfilter,
> > so I have to unref it at the last step of libavfilter, that's in
> buffersink. Any other suggestion? thanks.
>
> Sorry, I did not have this reply in my archives, I somehow missed it.
>
> What this is basically saying is that private_ref in libavfilter will be
> appropriated for the only use of bounding boxes. I think it is a
> significantly worse solution than using side data as you originally
> considered.
>
> Regards,
>
> --
>   Nicolas George
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".