[FFmpeg-devel] [PATCH v2] avformat: add a concat protocol that takes a line break delimited list of resources

[Nicolas George]

James Almer (12021-06-27):
> How is it not accurate enough?

Which characters must be escaped? Is it legal to escape another
character? Does it support single quotes like the other escaping
functions? Can you use byte or Unicode numbers?

Various escaping syntax have subtle differences about these points, and
this is something users need to know about, especially for scripts.

Anyway, our escaping syntax should be documented once well, with links
to it everywhere where needed, the description must not be duplicated
all over the place.

> I can add a line to the documentation stating that no other character needs
> to be escaped if that will make it more clear.

Make it a link to the unique good documentation of escaping.

If we do not have an unique good documentation of escaping, the it needs
to be written, and this is a good occasion. But I think we have it.

> The existing de-escaping functions will just remove backslashes, and the
> line break character will be parsed as a delimiter, which is why i wrote the
> above to ensure it is read as part of the filename.
> 
> The contents of the file are meant to be taken as is, and if you want the
> delimiter character to be part of the filename, you need to let the parser
> know about it. Every other character in the text file doesn't need to be
> escaped since this is not the command line where they could be interpreted
> as something else.

I know what the existing de-escaping functions do, and I know what they
can be used for, and I repeat: you can the parsing correctly with them
by reading the whole file at once.

But as it is, this code duplication is a big no.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210627/8e725378/attachment.sig>