[FFmpeg-devel] [PATCH] Avoid using the --preprocessor argument to windres

[Martin Storsjö]

On Thu, 17 Jun 2021, Martin Storsjö wrote:

> On Mon, 14 Jun 2021, Martin Storsjö wrote:
>
>> Instead use --preprocessor-arg; in binutils 2.36, the --preprocessor
>> flag was changed so that it no longer accepts a string containing
>> multiple arguments, but the whole --preprocessor argument is
>> treated as the path to the preprocessor executable (where the path
>> can contain spaces).
>> 
>> It's currently unclear whether this behaviour will stay or if it
>> is going to be reverted in the future, see discussion at [1]. Just
>> to be safe, avoid using the --preprocessor argument. Don't redeclare
>> the full preprocessing command, but just add the $(CC_DEPFLAGS) options.
>> 
>> Based on a patch by Kyle Schwartz.
>> 
>> [1] https://sourceware.org/bugzilla/show_bug.cgi?id=27594
>> ---
>> configure          | 1 -
>> ffbuild/common.mak | 2 +-
>> 2 files changed, 1 insertion(+), 2 deletions(-)
>> 
>
> OK'd by James Almer on irc, will push a bit later.

Pushed now.

I'll backport it to a couple older releases too, maybe next week (to let 
it sit in master for a little while first).

// Martin