[FFmpeg-devel] [PATCH v2 17/33] avdevice/dshow: discover source color range/space/etc

[James Almer]

On 6/14/2021 1:56 PM, Michael Niedermayer wrote:
> On Fri, Jun 11, 2021 at 10:30:48PM +0200, Diederick Niehorster wrote:
>> Enabled discovering a DirectShow device's color range, space, primaries,
>> transfer characteristics and chroma location, if the device exposes that
>> information. Sets them in the stream's codecpars.
>>
>> Signed-off-by: Diederick Niehorster <dcnieho at gmail.com>
>> Co-authored-by: Valerii Zapodovnikov <val.zapod.vz at gmail.com>
>> Signed-off-by: Diederick Niehorster <dcnieho at gmail.com>
>> ---
>>   libavdevice/dshow.c | 250 +++++++++++++++++++++++++++++++++++++++++++-
>>   1 file changed, 249 insertions(+), 1 deletion(-)
> 
> breaks build on mingw64
> 
> make
> CC	libavdevice/dshow.o
> src/libavdevice/dshow.c: In function ‘dshow_get_device_media_types’:
> src/libavdevice/dshow.c:415:23: warning: unused variable ‘ctx’ [-Wunused-variable]
>       struct dshow_ctx *ctx = avctx->priv_data;
>                         ^~~
> src/libavdevice/dshow.c: In function ‘dshow_get_device_list’:
> src/libavdevice/dshow.c:662:23: warning: unused variable ‘ctx’ [-Wunused-variable]
>       struct dshow_ctx *ctx = avctx->priv_data;
>                         ^~~
> src/libavdevice/dshow.c: In function ‘dshow_cycle_formats’:
> src/libavdevice/dshow.c:731:13: error: unknown type name ‘DXVA_ExtendedFormat’; did you mean ‘DXVA2_ExtendedFormat’?
>               DXVA_ExtendedFormat *extended_format_info = NULL;
>               ^~~~~~~~~~~~~~~~~~~
>               DXVA2_ExtendedFormat
> src/libavdevice/dshow.c:744:41: error: ‘AMCONTROL_COLORINFO_PRESENT’ undeclared (first use in this function)
>                   if (v->dwControlFlags & AMCONTROL_COLORINFO_PRESENT)
>                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~

$ grep -r AMCONTROL_COLORINFO_PRESENT /mingw64/x86_64-w64-mingw32/include/*
/mingw64/x86_64-w64-mingw32/include/dvdmedia.h:#define 
AMCONTROL_COLORINFO_PRESENT 0x00000080

Can you see if you can update your mingw-w64 toolchain, or at least the 
headers/crt? This is not the first time you get an error with new code.
Old mingw headers releases lacked a lot of API and are not 
representative of what a sane toolchain is meant to have.