[FFmpeg-devel] [PATCH] avformat/mxfdec: fixed jp2k_rsiz and 240M matrix

[Marton Balint]

On Sat, 5 Jun 2021, Marton Balint wrote:

>
>
> On Sat, 5 Jun 2021, Valerii Zapodovnikov wrote:
>
>> -static const uint8_t mxf_jp2k_rsiz[]                       = { 
>> 0x06,0x0e,0x2b,0x34,0x02,0x05,0x01,0x01,0x0d,0x01,0x02,0x01,0x01,0x02,0x01,0x00 
>> };
>> +static const uint8_t mxf_jp2k_rsiz[]                       = { 
>> 0x06,0x0e,0x2b,0x34,0x01,0x01,0x01,0x0a,0x04,0x01,0x06,0x03,0x01,0x00,0x00,0x00 
>> };
>
> Where does the original UL come from? Because based on the original patch 
> which added this key, I don't think it is a typo, it looks like this key was 
> added for a specific reason. So the better approach seems to be to rename the 
> old key to something like mxf_jp2k_rsiz_alternate, and check both the 
> official key and the old key.

On second look, it may well be a copy/paste typo indeed, because the 
specified key is for partition type OpenIncompleteHeaderPartition...

Patch looks good then.

Thanks,
Marton