[FFmpeg-devel] [PATCH] avformat/jacosubdec: Check for min in t overflow in get_shift()

Michael Niedermayer michael at niedermayer.cc
Sat Jun 5 17:30:14 EEST 2021


Fixes: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself
Fixes: 34651/clusterfuzz-testcase-minimized-ffmpeg_dem_JACOSUB_fuzzer-5157941012463616

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
 libavformat/jacosubdec.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libavformat/jacosubdec.c b/libavformat/jacosubdec.c
index c8bded02fe..1224d35bc4 100644
--- a/libavformat/jacosubdec.c
+++ b/libavformat/jacosubdec.c
@@ -141,6 +141,9 @@ static int get_shift(int timeres, const char *buf)
     int n = sscanf(buf, "%d"SSEP"%d"SSEP"%d"SSEP"%d", &a, &b, &c, &d);
 #undef SSEP
 
+    if (a == INT_MIN)
+        return 0;
+
     if (*buf == '-' || a < 0) {
         sign = -1;
         a = FFABS(a);
-- 
2.17.1



More information about the ffmpeg-devel mailing list