[FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

[Michael Niedermayer]

On Tue, Jun 01, 2021 at 06:22:24PM -0700, Mohammad Izadi wrote:
> HDR10+ metadata is stored in the bit stream for HEVC. The story is different for VP9 and cannot store the metadata in the bit stream. HDR10+ should be passed to packet side data an stored in the container (mkv) for VP9.
> 
> This CL is taking HDR10+ from AVFrame side data in libvpxenc and is passing it to the AVPacket side data.
> ---
>  doc/APIchanges         |  2 +
>  libavcodec/avpacket.c  |  1 +
>  libavcodec/decode.c    |  1 +
>  libavcodec/libvpxenc.c | 94 ++++++++++++++++++++++++++++++++++++++++++
>  libavcodec/packet.h    |  8 ++++
>  libavcodec/version.h   |  2 +-
>  6 files changed, 107 insertions(+), 1 deletion(-)

crashes

gdb --args ./ffmpeg_g -i ~/tickets/3562/issue3562_cut.avi -t 0.1  -bitexact -filter_complex '[0:0]format=yuv420p;[0:1]aresample=osr=22050' -y 3562.webm

Thread 1 "ffmpeg_g" received signal SIGSEGV, Segmentation fault.
0x000055555666c73e in av_fifo_size (f=0x0) at libavutil/fifo.c:79
79	    return (uint32_t)(f->wndx - f->rndx);
(gdb) bt
#0  0x000055555666c73e in av_fifo_size (f=0x0) at libavutil/fifo.c:79
#1  0x0000555555e42726 in free_hdr10_plus_fifo (fifo=0x5555575dbb30) at libavcodec/libvpxenc.c:346
#2  0x0000555555e42bfe in vpx_free (avctx=0x5555575db480) at libavcodec/libvpxenc.c:443
#3  0x0000555555bee381 in avcodec_close (avctx=0x5555575db480) at libavcodec/avcodec.c:472
#4  0x0000555555f31233 in avcodec_free_context (pavctx=0x5555575d0ad8) at libavcodec/options.c:163
#5  0x0000555555696ba0 in ffmpeg_cleanup (ret=0) at fftools/ffmpeg.c:609
#6  0x000055555568e51b in exit_program (ret=0) at fftools/cmdutils.c:135
#7  0x00005555556a8540 in main (argc=10, argv=0x7fffffffe1d8) at fftools/ffmpeg.c:5032


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210603/05835d63/attachment.sig>